Issue 1250 #1839
Merged
Issue 1250 #1839
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @DevPio, Nice improvment, thanks! I think it's ok for this to be merged, but first: would you mind updating your branch to get latest version? |
|
@michaelmaillot done! |
|
Merged manually, thank you! |
michaelmaillot
added a commit
that referenced
this pull request
Aug 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this Pull Request?
#1250
This PR introduces the ability to clear the selection in the SitePicker control when in single selection mode. It includes a custom renderer for the chevron icon, which now displays a "Cancel" icon alongside the chevron when an item is selected. Clicking the "Cancel" icon clears the current selection. The "Cancel" icon is only shown when an item is selected, ensuring a clean UI when there is no selection. These changes improve the user experience by making selection management more intuitive.